Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not the maximum resolution of the camera. #33

Open
yuya-tani opened this issue Oct 11, 2022 · 5 comments
Open

Not the maximum resolution of the camera. #33

yuya-tani opened this issue Oct 11, 2022 · 5 comments

Comments

@yuya-tani
Copy link

Hi.

In the Features part, there is "with FullHD resolution (or maximum supported by camera)."
How can I get the maximum resolution of the camera?

The camera supports 4K size, but even if aspectRatio is set to "16/9",
When you do "takePhoto", it is a FullHD (1980 x 1080) photo.

Is there any other way to set it?

Best regard.

@PercheEtienne
Copy link

Hi,

I have the same issue, did you find a solution ?

Thanks

@RyoheiTomiyama
Copy link

Maybe, max resolution is 1980x1980.
https://github.com/purple-technology/react-camera-pro/blob/master/src/components/Camera/Camera.tsx#L168-L176

For cameras with lower performance, it will be the camera's best image quality.

@nicholas-aponte
Copy link

Maybe, max resolution is 1980x1980. https://github.com/purple-technology/react-camera-pro/blob/master/src/components/Camera/Camera.tsx#L168-L176

For cameras with lower performance, it will be the camera's best image quality.

Is there a technical reason for this? or could the resolution be set via props so we can increase it?

@RyoheiTomiyama
Copy link

RyoheiTomiyama commented Sep 20, 2023

Is there a technical reason for this?

No, I used react-webcam and it worked!
https://codesandbox.io/p/github/RyoheiTomiyama/react_webcam_feature/main?file=/src/Camera/Camera.tsx:1,1

could the resolution be set via props so we can increase it?

react-camera-pro don't have props for the resolution, as far as I can find out.

@nicholas-aponte
Copy link

Is there a technical reason for this?

No, I used react-webcam and it worked! https://codesandbox.io/p/github/RyoheiTomiyama/react_webcam_feature/main?file=/src/Camera/Camera.tsx:1,1

could the resolution be set via props so we can increase it?

react-camera-pro don't have props for the resolution, as far as I can find out.

Thank you for the code snippet, I did not realize this ideal param could be used in the contraints

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants