Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limit parameter where possible #18

Open
bitboxer opened this issue Aug 17, 2011 · 5 comments
Open

Add limit parameter where possible #18

bitboxer opened this issue Aug 17, 2011 · 5 comments

Comments

@bitboxer
Copy link

There is no parameter to limit the queries, e.g. for user.getTopTracks , the API of last.fm offers this, but the rockstar gem doesn't use this right now.

@matiasleidemer
Copy link

I guess we still don't have this, right? Maybe I'll take a look :)

@bitboxer
Copy link
Author

No, this is still open. But I would welcome a PR with this 😉

@matiasleidemer
Copy link

I've been thinking a little bit about this and I came up with this solution...

Does it make any sense? I'd like to have some feedback or other opinions... What do you think @bitboxer, am I too far from it? Thanks!

@bitboxer
Copy link
Author

The only problem I might see: the default values. It might be good not to send anything if the pagination is not set. That way we don't interfere with the behavior of the communication if not needed.

Besides that: looking good!

@matiasleidemer
Copy link

Yeah, good catch. I'll change that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants