-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add limit parameter where possible #18
Comments
I guess we still don't have this, right? Maybe I'll take a look :) |
No, this is still open. But I would welcome a PR with this 😉 |
I've been thinking a little bit about this and I came up with this solution... Does it make any sense? I'd like to have some feedback or other opinions... What do you think @bitboxer, am I too far from it? Thanks! |
The only problem I might see: the default values. It might be good not to send anything if the pagination is not set. That way we don't interfere with the behavior of the communication if not needed. Besides that: looking good! |
Yeah, good catch. I'll change that. |
There is no parameter to limit the queries, e.g. for
user.getTopTracks
, the API of last.fm offers this, but the rockstar gem doesn't use this right now.The text was updated successfully, but these errors were encountered: