Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/704; Allow csp font locally #711

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

lkleisa
Copy link
Collaborator

@lkleisa lkleisa commented Jun 5, 2023

No description provided.

@lkleisa lkleisa linked an issue Jun 5, 2023 that may be closed by this pull request
@lkleisa lkleisa marked this pull request as ready for review June 5, 2023 14:45
@lkleisa lkleisa requested a review from mtnstar June 5, 2023 14:53
mtnstar
mtnstar previously requested changes Jun 7, 2023
Copy link
Member

@mtnstar mtnstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't load the font from an external source ... try to serve a copy from cryptopus assets

@lkleisa
Copy link
Collaborator Author

lkleisa commented Jun 7, 2023

After trying to use not external url, there is still this error in browser console: downloadable font: download failed (font-family: "text-security-disc" style:normal weight:400 stretch:100 src index:2): bad URI or cross-site access not allowed source: http://localhost:4200/text-security-disc-compat.ttf . Also the request to http://localhost:4200/text-security-disc-compat.ttf gets blocked because of cors. I tried to allow cors in rails with the rack-cors gem, but nothing worked..

@njaeggi
Copy link
Contributor

njaeggi commented Jun 8, 2023

I have also taken another look, tried different methods to allow cors or set the Access-Control-Allow-Origin header, nothing really worked, I also tried to just change the URL to localhost:3000 since we have the assets loaded there too. This also didn't work

@mtnstar mtnstar force-pushed the master branch 4 times, most recently from ecd3f3e to d610931 Compare June 21, 2023 14:08
@mtnstar mtnstar force-pushed the master branch 2 times, most recently from 520ebe8 to 151e944 Compare June 28, 2023 14:05
@lkleisa lkleisa marked this pull request as draft July 10, 2023 11:31
@kcinay055679 kcinay055679 marked this pull request as ready for review July 25, 2023 09:58
frontend/app/styles/secret-input.scss Outdated Show resolved Hide resolved
@kcinay055679 kcinay055679 dismissed stale reviews from TheWalkingLeek and mtnstar July 28, 2023 12:23

outdated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSP error locally
5 participants