Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing tokens (Pokecode) installieren #450

Open
larsUE opened this issue Jul 10, 2024 · 9 comments
Open

Sharing tokens (Pokecode) installieren #450

larsUE opened this issue Jul 10, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request, which significantly deviates from decidim core (modules excluded) waiting for deployment This feature/fix will be available with the next deployment.

Comments

@larsUE
Copy link
Collaborator

larsUE commented Jul 10, 2024

Hallo zusammen! Über den Sommer entwickelt Pokecode für uns bzw. den Decidim Core ein Modul, mit dem sich das Teilen von Componenten/Spaces etwas flexibler handhaben lässt. Da der Core diese Weiterentwicklung für V0.30 akzeptiert hat, müssen wir einen Backport erstellen, um es auf V0.27 zu haben. Pokecode fragt, was für uns der einfacher Weg wäre:

  1. Create a branch in a Decidim fork and backport the functionality there (for instance, ours) then we point your Decidim to use that branch in the Gemfile. This is the easiest solution for us (a bit less work and quicker). Why a fork? Because Decidim has this policy of not backporting new features, they won't backport these sharing improvements to version 0.27.
  2. Add overrides to your Decidim application, this means to create classes and views to backport the functionality just to you Decidim. It implies a bit more work for us, probably will consume a bit more time.

Ich danke euch für ein Feedback!

@larsUE larsUE added the question Further information is requested label Jul 10, 2024
@Robin481
Copy link
Member

Hallo @larsUE

Grundsätzlich denke ich das Punkt 1 auch für uns am meisten Sinn macht. Wir können, wie die Mitarbeitenden von Pokecode richtig sagen, einfach im Gemfile umstellen und gut ist.

Diese Lösung würde uns aber an den Fork von Pokecode fesseln bis wir auf Decidim 0.30 migriert haben.
Dies ist nicht zwingend ein Problem einfach eine Feststellung. Wenn wir sowieso von 0.27 direkt auf 0.30 gehen wollen ist es gar kein Thema.

Auch weiss ich nicht ob der Fork von Pokecode noch weitere Eigenheiten hat, das können sie dir aber wohl am besten selber beantworten. Wenn natürlich der Fork von Pokecode noch viele weitere Anpassungen hat ist es dann eventuell nicht nur ein Umstellen im Gemfile.
Auch könnte es natürlich sein das der Fork von Pokecode eigene Zusatzfeatures hat die dann beim Wechsel zurück auf "Vanilla" Decidim wieder wegfallen würden.

TLDR: Es kommt auf den Fork von Pokecode und dessen Eigenheiten an, aber grundsätzlich Punkt 1 👍

Cheers
Robin

@larsUE
Copy link
Collaborator Author

larsUE commented Jul 11, 2024

Yeah, thanks! Das hilft schon mal weiter.

@larsUE larsUE removed the question Further information is requested label Jul 11, 2024
@microstudi
Copy link

Hi everyone, we've finished the backport for the 0.27 version of this feature.
To use it, just use this branch in your Gemfile:

gem "decidim", github: "openpoke/decidim", branch: "backport/0.27/feature/share_unpublish_components_with_tokens"

Then proceed as usual with the commands bin/rails decidim:upgrade and bin/rails db:migrate

Ivan

@larsUE larsUE added the enhancement New feature or request, which significantly deviates from decidim core (modules excluded) label Sep 18, 2024
@Robin481
Copy link
Member

Robin481 commented Sep 19, 2024

Hello @larsUE

Switching to English so we all understand each other :)

Just to reiterate a few notes so we are on the same page:
If we start using the forked Decidim version we are completely reliant on it instead of the "standard" decidim version.
This means no more upgrades from the main decidim branch unless they are implemented in the forked version.
This means no updates happen if they don't happen in this forked branch until we jump to 0.30.
This is not to mean that we shouldn't do it, I just want us all to be aware of this 😃
@larsUE wanna give me a short Feedback that you are aware of this and want me to continue?

@larsUE
Copy link
Collaborator Author

larsUE commented Sep 19, 2024

Hmm, yes this may be an issue.

On the other hand: What would happen if the branch updates faster than we do?

@microstudi @paarals What are your thoughts on this?

@microstudi
Copy link

Let's see:

  1. The 0.27 branch series, we will keep update if news security fixes appear. For this, no worries. You can also ping us at any time to do it if we forget about it.
  2. We've just spoke with product and this feature will be integrated in the version 0.30. In case you want it for the 0.28 or 0.29 we should also create a backport for this. However, fear not, this is going to be an easy backport (as is the same design from the 0.28 and up)

@Robin481 Robin481 self-assigned this Sep 24, 2024
@larsUE
Copy link
Collaborator Author

larsUE commented Sep 24, 2024

@microstudi Cool, thanks a lot! Does this mean you're on V0.27.9 now? We'll be updating to that version as well.

And hooray for the core feature! We will most likely jump directly to V0.29 (or even 0.30 directly), approx. next Spring.

@larsUE
Copy link
Collaborator Author

larsUE commented Oct 1, 2024

@microstudi could you quickly confirm this? :-)

@microstudi
Copy link

@larsUE yes. it is in the 0.27.9 now that branch

@Robin481 Robin481 assigned Kagemaru and unassigned Robin481 Oct 1, 2024
@Kagemaru Kagemaru added the waiting for deployment This feature/fix will be available with the next deployment. label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request, which significantly deviates from decidim core (modules excluded) waiting for deployment This feature/fix will be available with the next deployment.
Projects
Development

No branches or pull requests

4 participants