Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not be able to get AuthenticationResult onComplete #17

Open
rkmax opened this issue May 19, 2019 · 2 comments
Open

Not be able to get AuthenticationResult onComplete #17

rkmax opened this issue May 19, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@rkmax
Copy link

rkmax commented May 19, 2019

Would be nice be able to use Authenticationresult

@pwittchen
Copy link
Owner

Hi,

Thannks for the suggestion. I think, library needs to be updated to move appropriate action to onNext(...) instead of onComplete() because onComplete() just indicates that stream is completed, but doesn't have place to pass arguments through its interface.

Regards,
Piotr

@pwittchen pwittchen added the enhancement New feature or request label May 20, 2019
@ksc91u
Copy link
Contributor

ksc91u commented Jul 21, 2019

I have a fork that pass Authentication Result.

I assume that if you wish to use Crypto object in Authentication Result to encrypt/decrypt
You need to set User Authentication Validity.

But due to an issue here : https://issuetracker.google.com/issues/132924498
I could not get User Authentication Validity to work properly.

Now my App just won't set User Authentication Validity.
So that crypto key is ready to use when created. But I only run the decrypt code when user pass authentication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants