Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: disable TLS termination #703

Closed
jhoblitt opened this issue Sep 15, 2023 · 2 comments
Closed

Feature request: disable TLS termination #703

jhoblitt opened this issue Sep 15, 2023 · 2 comments

Comments

@jhoblitt
Copy link

Is your feature request related to a problem? Please describe.

I would like to deploy pwm on k8s and have tls termination handled by an ingress controller (with certificates managed by cert-manager).

As of 2.0.6, it appears that tls termination is hard-wired on in the tomcat connector: https://github.com/pwm-project/pwm/blob/9fd838b93d2ef759c3c4ec49367cbe121356b076/onejar/src/main/java/password/pwm/onejar/TomcatOnejarRunner.java#L162-L163C5

Describe the solution you'd like

For my use cases, it would be completely satisfatory if pwm/tomcat didn't attempt to handle tls termination at all. An acceptable alternative would be an inverse to the manageHttps application option that completely disables https.

@jhoblitt
Copy link
Author

To work around this, the following annotation works with ingress-nginx:

    nginx.ingress.kubernetes.io/backend-protocol: "HTTPS"

@jrivard
Copy link
Contributor

jrivard commented Sep 18, 2023

Thanks for the suggestion, however as a security app, disabling TLS is not ideal, even if on a localhost or "secure" network. Instead, I think this is a better solution: issue #700. If this wouldn't work for your scenario please help us understand why. Thanks!

@jrivard jrivard closed this as completed Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants