-
-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from soundfile to torchaudio #360
Comments
soundfile
to torchaudio
Originally posted by @nryant in #347 (comment) Yes, if there are not currently unit tests, those should definitely be added first. Since this code is relevant for performance, we should probably also add some basic benchmarks so that we can check for regressions. Perhaps using airspeed velocity? As to changes to the underlying audio io in order to support additional formats, it seems that ideally the following four audio file formats would minimally be supported:
And the same table for reading a random 500 ms chunk of the same recording :
Do you want to open an issue and/or pull request to organize this work? |
Originally posted by @nryant in #347 (comment) After looking at the Maybe it would be safest to either depend on |
tests/data contains a bunch of 30-seconds AMI excerpts that can be used as sample WAV files for unit and speed tests. If that helps, they even come with a |
Closed by #492 |
pyannote.audio.features.utils
intopyannote.audio.features.io
pyannote.audio.features.io
on WAV filespyannote.audio.features.io
on WAV filessoundfile
totorchaudio
pyannote.audio.features.io
on main formats supported bytorchaudio
pyannote.audio.features.io
on main formats supported bytorchaudio
The text was updated successfully, but these errors were encountered: