Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PyO3 0.23 #11934

Closed
ngoldbaum opened this issue Nov 11, 2024 · 3 comments · Fixed by #11954
Closed

Support PyO3 0.23 #11934

ngoldbaum opened this issue Nov 11, 2024 · 3 comments · Fixed by #11954

Comments

@ngoldbaum
Copy link
Contributor

0.23 is basically complete right now. It looks like a lot of rust code will need to be updated:

$ cargo check --all --tests
...
error: could not compile `cryptography-rust` (lib test) due to 50 previous errors; 370 warnings emitted

See this gist for the full error output.

It looks like almost everything can be fixed mechanically or by following the migration guide in PyO3 for IntoPyObject. I don't see anything related to missing Sync impls, which is a good sign as far as eventual free-threading support goes.

@reaperhulk
Copy link
Member

We aggressively adopted the bound apis in the previous pyo3 releases so you can expect we’ll take a similar approach here.

@alex
Copy link
Member

alex commented Nov 11, 2024

Looks like the vast majority of these just need a sed.

@ngoldbaum
Copy link
Contributor Author

I opened #11954 which does most of the work.

@alex alex linked a pull request Nov 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants