-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert symmetric ciphers to Rust #9859
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
force-pushed
the
ciphers-rust
branch
4 times, most recently
from
November 11, 2023 14:13
a4cfd98
to
8e93a60
Compare
alex
added a commit
to alex/cryptography
that referenced
this pull request
Nov 11, 2023
This was referenced Nov 11, 2023
reaperhulk
pushed a commit
that referenced
this pull request
Nov 11, 2023
alex
force-pushed
the
ciphers-rust
branch
2 times, most recently
from
November 11, 2023 20:39
f32e9dd
to
6dcdd74
Compare
Merged
alex
added a commit
to alex/cryptography
that referenced
this pull request
Nov 11, 2023
reaperhulk
pushed a commit
that referenced
this pull request
Nov 11, 2023
alex
force-pushed
the
ciphers-rust
branch
6 times, most recently
from
November 12, 2023 16:34
f14ed65
to
ba17a34
Compare
alex
force-pushed
the
ciphers-rust
branch
3 times, most recently
from
November 23, 2023 02:18
e21b63b
to
e396dba
Compare
alex
force-pushed
the
ciphers-rust
branch
5 times, most recently
from
December 30, 2023 20:11
802f591
to
53fb74b
Compare
alex
force-pushed
the
ciphers-rust
branch
5 times, most recently
from
December 31, 2023 02:20
5edb99e
to
ba0c122
Compare
alex
force-pushed
the
ciphers-rust
branch
2 times, most recently
from
January 20, 2024 00:26
d7ed3ff
to
76e3858
Compare
alex
force-pushed
the
ciphers-rust
branch
3 times, most recently
from
January 30, 2024 01:28
b2b5f39
to
738d2be
Compare
Hi @alex! I'm hitting a deprecation regarding ARC4 when I use this branch, even when I'm not touching ARC4: >>> from cryptography.hazmat.primitives.ciphers import Cipher, algorithms, modes
>>> Cipher(algorithm=algorithms.AES(bytes(16)), mode=modes.ECB()).encryptor()
/path/to/env/lib/python3.11/site-packages/cryptography/hazmat/primitives/ciphers/base.py:107: CryptographyDeprecationWarning: ARC4 has been moved to cryptography.hazmat.decrepit.ciphers.algorithms.ARC4 and will be removed from this module in 48.0.0.
return rust_openssl.ciphers.create_encryption_ctx( |
I haven't updated this branch since @reaperhulk deprecated ARC4, I think |
alex
force-pushed
the
ciphers-rust
branch
2 times, most recently
from
February 5, 2024 10:51
b3a9f9c
to
05cac43
Compare
secdev/scapy#4285 should unblock us here. |
alex
force-pushed
the
ciphers-rust
branch
3 times, most recently
from
February 17, 2024 20:15
43274ff
to
06531f7
Compare
reaperhulk
reviewed
Feb 18, 2024
reaperhulk
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
update_unchecked
tosymm::Crypter
sfackler/rust-openssl#2100PyAEADEncryptionContext::update_into
bytes remaining checkPyAEADDecryptionContext::update
bytes remaining checkPyAEADDecryptionContext::update_into
bytes remaining checkPyAEADDecryptionContext::authenticate_additional_data
bytes remaining checkPyAEADDecryptionContext::finalize_with_tag
duplicate tag checkAlreadyUpdated
inPyAEADDecryptionContext::authenticate_additional_data
CffiMutBuf