Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If check=False execution becomes async #110

Open
cmannett85 opened this issue Aug 3, 2023 · 0 comments
Open

If check=False execution becomes async #110

cmannett85 opened this issue Aug 3, 2023 · 0 comments

Comments

@cmannett85
Copy link

If check=False is in the args then the run(..) function returns before execution has completed. I assume this is because CompletedProcess.returncode is a coroutine, so the calling thread doesn't block until it is accessed. When check=True this happens at the end of run(..).
jonashaag added a commit to jonashaag/subprocess-tee that referenced this issue Dec 22, 2023
@jonashaag
Add test for pycontribs#110
7e23a23
@jonashaag jonashaag mentioned this issue Dec 22, 2023
Merged
ssbarnea added a commit that referenced this issue Mar 4, 2024
@jonashaag @ssbarnea
Add test for #110 (#119)
d82470d 
* Add test for #110

* Fix

---------

Co-authored-by: Sorin Sbarnea <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cmannett85