Fix pygame.sprite.Group.has() behavior for no sprites given
#2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you motivate this change with an example of when this change would actually matter? Offhand, I can't come up with a valid use-case where it should matter what this returns if no sprites are passed |
|
Sure. |
|
I agree that this change is logical, but also, as pointed out before, it could be a backwards incompatible change that could break someones usage. |
MyreMylar
approved these changes
Jul 25, 2024
|
Thanks for the PR! Essentially this PR has my approval as well, I'm just drafting it for now because it cannot be merged right now for reasons Myre stated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
Group.has()returnTrueinstead ofFalsewhen no sprites (empty list, no arguments, etc.) are given.Closes #2993
This is potentially a breaking change. Might not get approved. See issue for discussion.