Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "collideswith" methods to "collide" #223

Open
itzpr3d4t0r opened this issue Jul 23, 2023 · 0 comments · May be fixed by #229
Open

Rename "collideswith" methods to "collide" #223

itzpr3d4t0r opened this issue Jul 23, 2023 · 0 comments · May be fixed by #229
Labels
type:cleanup Includes moving code, refactoring or reformat type:partial_rewrite Partially rewrites an existing feature

Comments

@itzpr3d4t0r
Copy link
Member

I suggest this change as it has two benefits:

  1. It would make people's code shorter and a bit more readable since the function name isn't composed of two words without space
  2. It would align more with the other collision functions which are in the form .collide* and not .collideswith*
@itzpr3d4t0r itzpr3d4t0r added type:cleanup Includes moving code, refactoring or reformat type:partial_rewrite Partially rewrites an existing feature labels Jul 23, 2023
@itzpr3d4t0r itzpr3d4t0r changed the title Rename "collideswith" function to "collide" Rename "collideswith" methods to "collide" Jul 30, 2023
@LaggyWolf LaggyWolf linked a pull request Dec 28, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:cleanup Includes moving code, refactoring or reformat type:partial_rewrite Partially rewrites an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rename 'collideswith' to 'collide' LaggyWolf/pygame-geometry
1 participant
@itzpr3d4t0r