Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve data selection in POST-TREATMENT #12

Open
ThibautVanHoof opened this issue May 18, 2021 · 5 comments
Open

Improve data selection in POST-TREATMENT #12

ThibautVanHoof opened this issue May 18, 2021 · 5 comments

Comments

@ThibautVanHoof
Copy link
Collaborator

The current data selection procedure is not easy to use in case of large amount of data on the disk. A filtering approach is more user friendly in such case(see the LBMHYPE prototype).

Moreover, the selection table are showed in the main window and the plot itself is below and often off screen. It is more convenient to reserve the main window to the plot and put the filtering tools in the left part of the window.

@ThibautVanHoof
Copy link
Collaborator Author

Here are some more precise requests to improve the current interface:

Screenshot from 2021-06-22 12-23-26

  • The scheme names do not corresponds to the scheme name in the SCHEME tab (D1Q333 instead of D1Q333_0 or D1Q333_1)
  • Same for the test case name (always 'ToroCase' while both the 'Toro1' and 'Toro2' case have been performed in the example file)
  • the 'directory' column shows absolute path hardly readible. Please use path relative wrt. ./Outputs in order to reduce the length of the line; or propose another column 'RelativePath' with such a shorter relative path
  • what is the purpose of the 'id' column? How can the user use the provided hexadécimal code?

@gouarin
Copy link
Member

gouarin commented Jun 24, 2021

This will be done in the future version since we have to be able to import each test case and each lb scheme in order to have their name. But, to achieve this, pylbm-catalog should be released.

I prefer to keep the absolute path but we can add the relative path as another entry.

The id can be hidden.

@gouarin
Copy link
Member

gouarin commented Jun 24, 2021

oh wait, I have added the v_model entry which makes what we want for the name of the test case and the lb scheme.

I will make the changes accordingly.

@gouarin
Copy link
Member

gouarin commented Jun 24, 2021

The id was removed and the names are now correct.
see bad1d62

@ThibautVanHoof
Copy link
Collaborator Author

Screenshot from 2021-06-25 09-15-35

  • the field names associated with the responses 'plot FIELDNAME' in the h5 file are always 'sol' while it must be FIELDNAME (see the snapshot where 'plot momentum' and 'plot mass' are requested and plotted using the POST TREATMENT tool).
  • Could you please add the relative path as entry since the absolute path are VERY inconvenient for the analyze of large database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants