Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip installed version do not seem to include the .svg files #226

Open
cphyc opened this issue Sep 19, 2023 · 3 comments
Open

pip installed version do not seem to include the .svg files #226

cphyc opened this issue Sep 19, 2023 · 3 comments

Comments

@cphyc
Copy link
Contributor

cphyc commented Sep 19, 2023

When doing a pip install of tangos, it seems the web GUI cannot properly find the SVG files required to display the filtering (see image attached below)

This is what I get when installing tangos from source with pip install -e .
image

When doing pip install . or pip install tangos, the ^ and v and filter svg symbols do not display. When inspecting the HTML, these SVGs are actually pointing to URLs with a 404 error.

@apontzen
Copy link
Member

Oh dear! Any ideas why?

@cphyc
Copy link
Contributor Author

cphyc commented Sep 19, 2023

The issue is that the SVG files aren't included in the MANIFEST. The following patch seems to do the trick

diff --git a/MANIFEST.in b/MANIFEST.in
index 06996e6..81b38df 100644
--- a/MANIFEST.in
+++ b/MANIFEST.in
@@ -1 +1 @@
-recursive-include tangos *.png *.css *.gif *.js *.jinja2 *.ini
+recursive-include tangos *.png *.css *.gif *.js *.jinja2 *.ini *.svg

@apontzen
Copy link
Member

Thanks, #227 implements this and also deals with a failing unit test on recent versions of numpy (I hope, awaiting the CI results)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants