Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress spinner: buggy behavior in some terminal emulators #135

Closed
woodruffw opened this issue Nov 22, 2021 · 2 comments · Fixed by #136
Closed

Progress spinner: buggy behavior in some terminal emulators #135

woodruffw opened this issue Nov 22, 2021 · 2 comments · Fixed by #136
Labels
bug Something isn't working component:cli CLI components

Comments

@woodruffw
Copy link
Member

I've noticed this behavior in both iTerm and Alacritty on macOS: sometimes pip-audit's spinner will render once per line, rather than sticking to the same line.

Here's the buggy behavior on Alacritty:

asciicast

and iTerm 2:

asciicast

and here is is working correctly in Terminal.app:

asciicast

I'm not really sure what's up with this: it only seems to happen when pip-audit is used with a requirements source rather than an environmental source, so it might be caused either by something we're printing differently for that source or by the slower steps in between actions. Needs debugging.

@woodruffw woodruffw added bug Something isn't working component:cli CLI components labels Nov 22, 2021
@di
Copy link
Member

di commented Nov 22, 2021

Looks like this happens when the line to be printed exceeds the width of the terminal:

https://asciinema.org/a/TIkTlhSX63EAFcbhmXf1hhU99

@woodruffw
Copy link
Member Author

woodruffw commented Nov 22, 2021

Thanks for catching that! This looks like the upstream issue: verigak/progress#40

Edit: And probably the same bug manifesting in pip: pypa/pip#6101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component:cli CLI components
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants