diff --git a/setupsrc/pypdfium2_setup/autorelease.py b/setupsrc/pypdfium2_setup/autorelease.py index b4bcac58c..520f712c4 100644 --- a/setupsrc/pypdfium2_setup/autorelease.py +++ b/setupsrc/pypdfium2_setup/autorelease.py @@ -96,20 +96,16 @@ def log_changes(summary, prev_pdfium, new_pdfium, new_tag, beta): Changelog.write_text(content) -# NOTE git add: places don't need to have been changed, git silently skips this -# NOTE tag: The actually published tag will be a different one (though with same name), but it's nevertheless convenient to have this here because of changelog and git describe def register_changes(new_tag): run_local(["git", "checkout", "-B", "autorelease_tmp"]) run_local(["git", "add", *PlacesToRegister]) run_local(["git", "commit", "-m", f"[autorelease main] update {new_tag}"]) + # Note, the actually published tag will be a different one (though with same name), but it's nevertheless convenient to have this here because of changelog and git describe run_local(["git", "tag", "-a", new_tag, "-m", "Autorelease"]) -# FIXME takes many parameters ... -# FIXME log fails if args.register is False - skip, or use HEAD and omit ver_b ? -# TODO add GH compare link? -# TODO consider skipping URLs for pypdfium2 (GH links commits automatically) ? def _get_log(name, url, cwd, ver_a, ver_b, prefix_ver, prefix_commit, prefix_tag): + # known issue: log fails if args.register is False log = "" log += "\n
\n" log += f" {name} commit log\n\n" @@ -122,10 +118,11 @@ def _get_log(name, url, cwd, ver_a, ver_b, prefix_ver, prefix_commit, prefix_tag log += "\n\n
\n" return log -# FIXME is there a faster way to get pdfium's commit log? -# TODO should we specifically show changes to public/ ? + def make_releasenotes(summary, prev_pdfium, new_pdfium, prev_tag, new_tag, c_updates): + # TODO specifically show changes to public/ ? + relnotes = "" relnotes += f"## Changes (Release {new_tag})\n\n" relnotes += "### Summary (pypdfium2)\n\n"