Resolves https://github.com/pypr/cyarray/issues/13 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partial fix for pypr#13 thanks prajwal
cython>3.0 disallows setting `ndarray.data=<char *>some_data`. I believe `ndarray.data=<char *>some_data` is being used in the first place because it is more efficient than using `PyArray_SimpleNewFromData`, maybe. So, this cython restriction is overcome with a fix from https://github.com/rainwoodman/pandas/blob/05d3fe2402e4563124e7060837ded7513ab5bca7/pandas/_libs/reduction.pyx#L27 interim partial fix for pypr#13
nauaneed
force-pushed
the
fix-cy3
branch
6 times, most recently
from
575e6ad
to
a2bbae1
Compare
nauaneed
changed the title
nauaneed
changed the title
nauaneed
changed the title
prabhuramachandran
requested changes
Aug 17, 2023
cyarray/carray.pyx.mako
Outdated
| @@ -43,7 +43,7 @@ IF UNAME_SYSNAME == "Windows": | |||
| ELSE: | |||
| from libc.stdint cimport uintptr_t | |||
|
|
|||
| cimport numpy as np | |||
| cimport numpy as npqq | |||
`python setup.py` fails on macos and windows so using `pip install .`
- these changed were motivated by deprecation warnings in workflow run logs
prabhuramachandran
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put together a fix for #13. This might be unclean, but
cyarrayinstalls now. Could work until there is a better fix, maybe?