Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves https://github.com/pypr/cyarray/issues/13 #14

Merged
merged 6 commits into from
Aug 18, 2023
Merged

Resolves https://github.com/pypr/cyarray/issues/13 #14

merged 6 commits into from
Aug 18, 2023

Commits on Aug 17, 2023

  1. fix: 'language_level' not set warning when cythonizing

    @nauaneed
    nauaneed committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    b6d4098 View commit details
    Browse the repository at this point in the history

  2. fix(cyarray.pyx.mako): int division 

    partial fix for pypr#13
thanks prajwal
    @nauaneed
    nauaneed committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    9401f23 View commit details
    Browse the repository at this point in the history

  3. fix(cyarray.pyx.mako): resetting ndarray.data 

    cython>3.0 disallows setting `ndarray.data=<char *>some_data`.

I believe `ndarray.data=<char *>some_data` is being used in the first
place because it is more efficient than using
`PyArray_SimpleNewFromData`, maybe.

So, this cython restriction is overcome with a
fix from https://github.com/rainwoodman/pandas/blob/05d3fe2402e4563124e7060837ded7513ab5bca7/pandas/_libs/reduction.pyx#L27

interim partial fix for pypr#13
    @nauaneed
    nauaneed committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    3d7fb67 View commit details
    Browse the repository at this point in the history

  4. test: cope with np.int deprecation

    @nauaneed
    nauaneed committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    d2f8184 View commit details
    Browse the repository at this point in the history

  5. ci(gha): fix installation on mac,win 

    `python setup.py` fails on macos and windows so using `pip install .`
    @nauaneed
    nauaneed committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    555e111 View commit details
    Browse the repository at this point in the history

  6. ci(gha): use updated actions 

    - these changed were motivated by deprecation warnings in workflow run
  logs
    @nauaneed
    nauaneed committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    2c50550 View commit details
    Browse the repository at this point in the history