Bump Cython Old #18
Bump Cython Old #18
Conversation
|
This is not bad, either. |
since support for usage of DEF/IF is expected to be removed, IF are remove from code as well.
cyarray/msstdint.h was added in 24c49cc since stdint.h has not been there pre MSVC2015. It should be fine to remove this now.
nauaneed
force-pushed
the
bump-cython-old
branch
2 times, most recently
from
d0c464b
to
c482445
Compare
cython>3.0 disallows setting `ndarray.data=<char *>some_data`. This commit introduces a dirty workaround for this.
- all nogil prefixed with noexcept
nauaneed
force-pushed
the
bump-cython-old
branch
from
c482445
to
58dd4ad
Compare
nauaneed
force-pushed
the
bump-cython-old
branch
6 times, most recently
from
ef6a1d3
to
f157c4e
Compare
| @@ -2,7 +2,7 @@ | |||
| requires = [ | |||
| "wheel>=0.29.0", | |||
| "setuptools>=42.0.0", | |||
| "oldest-supported-numpy", | |||
| "Cython<3.0", | |||
| "numpy", | |||
There was a problem hiding this comment.
Is it recommended to use "numpy" instead of "oldest-supported-numpy" now?
There was a problem hiding this comment.
I am not sure if that is recommended, but the problem is this:
requirements.txt and setup.py have just "numpy". So, pip install -r requirements.txt installs the latest numpy.
Then with pip install -e . cyarray is compiled with oldest-supported-numpy as specified in pyproject.toml.
Eventually it ends up with,
ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject
like here: https://github.com/pypr/cyarray/actions/runs/10434451995/job/28897324886
There was a problem hiding this comment.
Hmm, so what is the oldest-supported-numpy version here? Is it < 2.0?
cyarray/carray.pyx.mako
Outdated
|
|
||
| cimport numpy as np | ||
| np.import_array(); |
There was a problem hiding this comment.
Please remove the semicolon.
There was a problem hiding this comment.
I have amended this and force pushed now.
pyproject.toml specified oldest supported numpy. This is changed. The .pyx file is also updated to avoid avoid errors.
nauaneed
force-pushed
the
bump-cython-old
branch
from
f157c4e
to
c7c2068
Compare
Old fix from https://github.com/rainwoodman/pandas/blob/05d3fe2402e4563124e7060837ded7513ab5bca7/pandas/_libs/reduction.pyx#L27