Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the assumption made by merge nearest network #1056

Open
virio-andreyana opened this issue Jul 9, 2024 · 0 comments
Open

Improve the assumption made by merge nearest network #1056

virio-andreyana opened this issue Jul 9, 2024 · 0 comments

Comments

@virio-andreyana
Copy link
Contributor

@ekatef @davide-f

Feature request

grafik

This is the raw results of the function merge_into_network() in simplify network.py. This didn‘t solve the issue because

  • it overconnects in one region (Indonesia, Singapore)
  • It still left some regions fully disconnected (myanmar, cambodia)
    There must be a logical assumption where buses connects to the nearest network

Originally I would like to create a function that does similar to merge_into_network() with this assumption

  • The bus in question must be a stub or an isolated node
  • It must have a tolerance radius to not overextend
  • Do not connect to the same subnetwork
  • Do not go through waters
  • Do not go across national border

This is different from merge_into_network() because

  • Stubs are removed before merge_into_network() are run, not after
  • The use of tolerance radius in gpd.sjoin_nearest()
  • Not bypassing the offshore shapefiles

The rest behave quite similar.

I tried to create this code myself, but it always causes novel error in the use of busmap with minimal impact on connections. I was wondering if you can improve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant