-
Notifications
You must be signed in to change notification settings - Fork 79
"Implement Cassandra index in terms of index interface" broke querying with cassandra index #209
Comments
(forgive any lack of precision, I don't speak Clojure so I'm stumbling around in the dark here a bit.) |
Thanks for reporting! The first implementation was a bit overtuned. We've already done some work on improving it and working on more improvements. Having that said, it should be fixed in latest master. |
Sorry if I wasn't clear. It's broken for me on current master . I get Internal Server Error / NPE for any render other than ones that return no data points. |
I'll take a closer look at it tonight. I've been testing against grafana proxy, which might be a bit different setting. I'll take a closer look at how graphite-cyanite integrates. |
Yes, I was getting similar problems using graphite-api, and this made everything happier: diff --git a/src/io/cyanite/index/cassandra.clj b/src/io/cyanite/index/cassandra.clj (defn prefix-info |
fc85da5 changed
prefixes
to return something without a "path" key, which is inconsistent with other indexes, and causes a NPE like so: https://gist.github.com/arodland/2218ee4af35b2a38adb40263f86d54d4 .Adding
:path path
toprefix-info
fixes the NPE, but is probably far from the best fix.Relatedly, there is brutasse/graphite-cyanite#21 which relates to graphite-api being broken by the same dropping of
path
at the API layer.The text was updated successfully, but these errors were encountered: