Fix the way obsolete messages are stored #1132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1132 +/- ##
=======================================
Coverage 91.26% 91.26%
=======================================
Files 27 27
Lines 4602 4602
=======================================
Hits 4200 4200
Misses 402 402
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1124
Previously, the
Catalog.obsoletedictionary would use themsgidas a key to store messages.When there are two messages with the same id but a different context, the latter one overwrites the former.
The fix is to use
Catalog._get_keyas the key, same as for_messages.This might be considered a breaking change, however the only documentation for
Catalog.obsoleteis this:The docs never say anything about how the keys are computed, so I think it should be safe to make this change (and perhaps document it too?)