Added type hints to ImageFile.__init__() #8336
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from the obvious type hinting, this has two changes.
Require
fp
inPillow/src/PIL/ImageFile.py
Lines 107 to 110 in 44c2ff3
It will become the stream that is used by plugins, so there's no reason for it to be
None
.Rather than allowing
im.tile
to beNone
Pillow/src/PIL/ImageFile.py
Line 117 in 44c2ff3
Pillow/src/PIL/ImageFile.py
Lines 178 to 185 in 44c2ff3
I have changed the check to
Pillow/src/PIL/ImageFile.py
Line 189 in d00f365
as it seems simpler from a type hinting perspective. If there is no tile to load, and no core image object already loaded, then this image cannot be loaded.