Added type hints #8354
Merged
Added type hints #8354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
approved these changes
Sep 7, 2024
src/PIL/TiffImagePlugin.py
Outdated
Comment on lines
2111
to
2120
| if sys.version_info >= (3, 12): | ||
| from collections.abc import Buffer | ||
|
|
||
| def write(self, data: Buffer, /) -> int: | ||
| return self.f.write(data) | ||
|
|
||
| else: | ||
|
|
||
| def write(self, data: Any, /) -> int: | ||
| return self.f.write(data) |
There was a problem hiding this comment.
Perhaps something like this?
Suggested change
| if sys.version_info >= (3, 12): | |
| from collections.abc import Buffer | |
| def write(self, data: Buffer, /) -> int: | |
| return self.f.write(data) | |
| else: | |
| def write(self, data: Any, /) -> int: | |
| return self.f.write(data) | |
| if sys.version_info >= (3, 12): | |
| from collections.abc import Buffer | |
| else: | |
| Buffer = Any | |
| def write(self, data: Buffer, /) -> int: | |
| return self.f.write(data) |
There was a problem hiding this comment.
Sure. I've actually moved Buffer into src/PIL/_typing.py so that this change can occur for GifImagePlugin cleanly as well.
radarhere
force-pushed
the
type_hint
branch
2 times, most recently
from
253f6d9
to
f6f9c8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.