Change harfbuzz versions in wheels #8421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's an issue about upgrading Ubuntu in the base image: google/oss-fuzz#11835 |
|
You can pip install meson on oss-fuzz build scripts, that is how we build HarfBuzz there (you might also want to bin meson version to a known working one, since new meson versions sometimes break build, at least in the past). |
|
Thanks for the suggestion! I've created #8424 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes here.
More specifically though, it now requires meson >= 0.55.
This is a problem, as the base image for oss-fuzz uses Ubuntu 20.04, which only has meson 0.53.2
So this PR downgrades harfuzz on OSS Fuzz to the version before meson became mandatory. I've used the environment variable 'SANITIZER' to detect OSS Fuzz.