Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The value of start_index should be greater than zero #84

Open
Meow-Knight opened this issue Oct 22, 2024 · 2 comments
Open

The value of start_index should be greater than zero #84

Meow-Knight opened this issue Oct 22, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Meow-Knight
Copy link

According to this SCIM section, if the value of startIndex less than 1 SHALL be interpreted as 1.
So, I think we should use max(1, value) in this LOC, instead of max(0, value)
@azmeuk azmeuk added the bug Something isn't working label Oct 22, 2024
@azmeuk
Copy link
Contributor

azmeuk commented Oct 22, 2024

Nice catch. Do you want to open a PR?

@Meow-Knight
Copy link
Author

@azmeuk Sure! I'm happy to create a PR to cover this case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@azmeuk @Meow-Knight