From 7438b8ebee3f6ef59c15b86d627d32f98f49df8f Mon Sep 17 00:00:00 2001 From: Aymeric Augustin Date: Tue, 12 Nov 2024 08:40:24 +0100 Subject: [PATCH] Stop testing on PyPy 3.9. PyPy v7.3.17 no longer provides PyPy 3.9. Also the test suite was flaky under PyPy 3.9. --- .github/workflows/tests.yml | 3 --- tests/sync/test_connection.py | 5 ----- 2 files changed, 8 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index beaf9d12..5ab9c4c7 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -60,13 +60,10 @@ jobs: - "3.11" - "3.12" - "3.13" - - "pypy-3.9" - "pypy-3.10" is_main: - ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }} exclude: - - python: "pypy-3.9" - is_main: false - python: "pypy-3.10" is_main: false steps: diff --git a/tests/sync/test_connection.py b/tests/sync/test_connection.py index 4884bf13..e21e310a 100644 --- a/tests/sync/test_connection.py +++ b/tests/sync/test_connection.py @@ -1,6 +1,5 @@ import contextlib import logging -import platform import socket import sys import threading @@ -564,10 +563,6 @@ def test_close_idempotency(self): self.connection.close() self.assertNoFrameSent() - @unittest.skipIf( - platform.python_implementation() == "PyPy", - "this test fails randomly due to a bug in PyPy", # see #1314 for details - ) def test_close_idempotency_race_condition(self): """close waits if the connection is already closing."""