Skip to content
This repository has been archived by the owner on Nov 23, 2017. It is now read-only.

there are too many code in /example are using: from asyncio import * #464

Open
hanbeibei opened this issue Nov 14, 2016 · 2 comments
Open

there are too many code in /example are using: from asyncio import * #464

hanbeibei opened this issue Nov 14, 2016 · 2 comments
Labels
help wanted

Comments

@hanbeibei
Copy link

does this adapt to pep8?

I was told not to write code in this way. this will add more work to the people who want to use your work, we are not writing perl.
@gvanrossum
Copy link
Member

You're right, the examples should be changed to just import what they need.

Do you want to help by submitting a PR?

@denisra
Copy link

denisra commented Nov 16, 2016

I'm willing to work on this one if nobody else is doing it yet.

denisra added a commit to denisra/asyncio that referenced this issue Nov 16, 2016
@denisra
Changed all the import statements in all modules in the examples
3863b43 
directory to import only what is needed.

This fix issue python#464
@denisra denisra mentioned this issue Nov 16, 2016
Open
denisra added a commit to denisra/asyncio that referenced this issue Nov 16, 2016
@denisra
Some minor improvements on coding style.
5e4efd7 
Fixes issue python#464
@denisra denisra mentioned this issue Nov 18, 2016
Open
denisra added a commit to denisra/asyncio that referenced this issue Nov 18, 2016
@denisra
Changed all the import statements in all modules in the examples
a5df171 
directory to import only what is needed.

This fix issue python#464
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@1st1 @gvanrossum @hanbeibei @denisra