Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace frame->prev_instr by frame->instr_ptr #109094

Closed
iritkatriel opened this issue Sep 7, 2023 · 0 comments
Closed

Replace frame->prev_instr by frame->instr_ptr #109094

iritkatriel opened this issue Sep 7, 2023 · 0 comments
Assignees
@iritkatriel
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@iritkatriel
Copy link
Member

iritkatriel commented Sep 7, 2023 •
edited by bedevere-app bot
Loading

frame->prev_instr has confusing semantics, we will replace it by a new field instr_ptr which is

(1) the instruction currently executing (if any), or
(2) the next instruction to execute on the frame (otherwise).

Linked PRs
@iritkatriel iritkatriel self-assigned this Sep 7, 2023
@iritkatriel iritkatriel added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Sep 7, 2023
This was referenced Sep 7, 2023
Merged
Merged
iritkatriel added a commit that referenced this issue Sep 7, 2023
@iritkatriel
gh-109094: remove unnecessary updates of frame->prev_instr in instrum…
9639696 
…entation functions (#109076)
@iritkatriel iritkatriel mentioned this issue Sep 26, 2023
Closed
@bedevere-app bedevere-app bot mentioned this issue Oct 12, 2023
Merged
markshannon pushed a commit that referenced this issue Oct 12, 2023
@iritkatriel
gh-109094: remove redundant arg to _PyFrame_PushTrampolineUnchecked (G…
7dd3c2b 
…H-110759)
iritkatriel added a commit that referenced this issue Oct 26, 2023
@iritkatriel
gh-109094: replace frame->prev_instr by frame->instr_ptr (#109095)
67a91f7
@markshannon markshannon mentioned this issue Jan 9, 2024
Closed
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@iritkatriel @aisk
pythongh-109094: replace frame->prev_instr by frame->instr_ptr (pytho…
bc7df6b 
…n#109095)
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@iritkatriel @Glyphack
pythongh-109094: remove redundant arg to _PyFrame_PushTrampolineUnche…
9264ed7 
…cked (pythonGH-110759)
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@iritkatriel @Glyphack
pythongh-109094: replace frame->prev_instr by frame->instr_ptr (pytho…
feb4455 
…n#109095)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iritkatriel iritkatriel

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iritkatriel