Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qidarg_converter_data Values Not Properly Initialized #125667

Closed
ericsnowcurrently opened this issue Oct 17, 2024 · 0 comments
Closed

qidarg_converter_data Values Not Properly Initialized #125667

ericsnowcurrently opened this issue Oct 17, 2024 · 0 comments
Assignees
@ericsnowcurrently
Labels
3.13 bugs and security fixes 3.14 new features, bugs and security fixes extension-modules C modules in the Modules dir topic-subinterpreters type-bug An unexpected behavior, bug, or error

Comments

@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Oct 17, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

In #124548 (comment), @ZeroIntensity noted that the various locals of type qidarg_converter_data in _interpqueuesmodule.c are not statically initialized. Whether or not they are initialized to zeros by default is "undefined behavior, ergo depends on the compiler. This could be a problem since the corresponding arg converter func branches on whether or the "label" field is NULL. This may (or may not) be related to the buildbot failures noted in that other issue.

Fixing this will be fairly trivial.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs
@ericsnowcurrently ericsnowcurrently added type-bug An unexpected behavior, bug, or error extension-modules C modules in the Modules dir topic-subinterpreters 3.13 bugs and security fixes 3.14 new features, bugs and security fixes labels Oct 17, 2024
@ericsnowcurrently ericsnowcurrently self-assigned this Oct 17, 2024
@ericsnowcurrently ericsnowcurrently mentioned this issue Oct 17, 2024
Merged
@bedevere-app bedevere-app bot mentioned this issue Oct 17, 2024
Merged
ericsnowcurrently added a commit that referenced this issue Oct 17, 2024
@ericsnowcurrently
gh-125667: Statically Initialize the Arg Converter Data Values in _in…
7cf2dbc 
…terpqueuesmodule.c (gh-125668)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 17, 2024
@ericsnowcurrently @miss-islington
pythongh-125667: Statically Initialize the Arg Converter Data Values …
70526e7 
…in _interpqueuesmodule.c (pythongh-125668)

(cherry picked from commit 7cf2dbc)

Co-authored-by: Eric Snow <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Oct 17, 2024
Merged
ericsnowcurrently added a commit that referenced this issue Oct 18, 2024
@miss-islington @ericsnowcurrently
[3.13] gh-125667: Statically Initialize the Arg Converter Data Values…
e57831f 
… in _interpqueuesmodule.c (gh-125670)

gh-125667: Statically Initialize the Arg Converter Data Values in _interpqueuesmodule.c (gh-125668)
(cherry picked from commit 7cf2dbc)

Co-authored-by: Eric Snow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericsnowcurrently ericsnowcurrently

Labels
3.13 bugs and security fixes 3.14 new features, bugs and security fixes extension-modules C modules in the Modules dir topic-subinterpreters type-bug An unexpected behavior, bug, or error
Projects
Subinterpreters
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ericsnowcurrently