Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove un-necessary socket requirements in contextlib async tests #128234

Closed
graingert opened this issue Dec 25, 2024 · 0 comments
Closed

Remove un-necessary socket requirements in contextlib async tests #128234

graingert opened this issue Dec 25, 2024 · 0 comments
Labels
tests Tests in the Lib/test dir topic-asyncio

Comments

@graingert
Copy link
Contributor

graingert commented Dec 25, 2024 •
edited by bedevere-app bot
Loading

Proposal:

the contextlib async tests should run coroutines using coro.send(None) because they don't need an async framework to run. This would remove asyncio from the tests and support running on emscripten/wasi

Linked PRs
@graingert graingert added type-feature A feature request or enhancement and removed type-feature A feature request or enhancement labels Dec 25, 2024
@bedevere-app bedevere-app bot mentioned this issue Dec 25, 2024
Merged
@picnixz picnixz added tests Tests in the Lib/test dir topic-asyncio labels Dec 25, 2024
@github-project-automation github-project-automation bot moved this to Todo in asyncio Dec 25, 2024
@picnixz picnixz changed the title the contextlib async tests requires a working socket to run, when it could run without using sockets at all Remove un-necessary socket requirements in contextlib async tests Dec 25, 2024
kumaraditya303 added a commit that referenced this issue Dec 25, 2024
@graingert @kumaraditya303
gh-128234: support emscripten and wasi in async contextlib tests by r…
81636d3 
…emoving asyncio from contextlib async tests (#95888)

Co-authored-by: Kumar Aditya <[email protected]>
@github-project-automation github-project-automation bot moved this from Todo to Done in asyncio Dec 25, 2024
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
@graingert @kumaraditya303 @srinivasreddy
pythongh-128234: support emscripten and wasi in async contextlib test…
6ee8471 
…s by removing asyncio from contextlib async tests (python#95888)

Co-authored-by: Kumar Aditya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir topic-asyncio
Projects
asyncio
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@graingert @picnixz @kumaraditya303