Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BOLT uses deprecated option -reorder-functions=hfsort+ #128456

Closed
zanieb opened this issue Jan 3, 2025 · 0 comments · Fixed by #128457
Closed

BOLT uses deprecated option -reorder-functions=hfsort+ #128456

zanieb opened this issue Jan 3, 2025 · 0 comments · Fixed by #128457
Labels
build The build process and cross-build type-bug An unexpected behavior, bug, or error

Comments

@zanieb
Copy link
Contributor

zanieb commented Jan 3, 2025 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

Building with BOLT optimizations emits the following warning

BOLT-WARNING: '-reorder-functions=hfsort+' is deprecated, please use '-reorder-functions=cdsort' instead

From the usage at

cpython/configure.ac

Line 2186 in 6fd3184

-reorder-functions=hfsort+

The resolution looks quite straight-forward, I'll post a patch.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs
@zanieb zanieb added the type-bug An unexpected behavior, bug, or error label Jan 3, 2025
@picnixz picnixz added the build The build process and cross-build label Jan 3, 2025
@bedevere-app bedevere-app bot mentioned this issue Jan 3, 2025
Merged
@erlend-aasland erlend-aasland linked a pull request Jan 3, 2025 that will close this issue
gh-128456: Use -reorder-functions=cdsort for BOLT #128457
Merged
erlend-aasland pushed a commit that referenced this issue Jan 3, 2025
@zanieb
gh-128456: Use '-reorder-functions=cdsort' for BOLT builds (#128457)
4974bbd 
'hfsort+' is deprecated in favor of 'cdsort'.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 3, 2025
@zanieb @miss-islington
pythongh-128456: Use '-reorder-functions=cdsort' for BOLT builds (pyt…
fc5a56c 
…honGH-128457)

'hfsort+' is deprecated in favor of 'cdsort'.
(cherry picked from commit 4974bbd)

Co-authored-by: Zanie Blue <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 3, 2025
@zanieb @miss-islington
pythongh-128456: Use '-reorder-functions=cdsort' for BOLT builds (pyt…
f7d11ed 
…honGH-128457)

'hfsort+' is deprecated in favor of 'cdsort'.
(cherry picked from commit 4974bbd)

Co-authored-by: Zanie Blue <[email protected]>
This was referenced Jan 3, 2025
Merged
Merged
erlend-aasland pushed a commit that referenced this issue Jan 3, 2025
@miss-islington @zanieb
[3.12] gh-128456: Use '-reorder-functions=cdsort' for BOLT builds (GH…
d56e502 
…-128457) (#128462)

'hfsort+' is deprecated in favor of 'cdsort'.

(cherry picked from commit 4974bbd)

Co-authored-by: Zanie Blue <[email protected]>
erlend-aasland pushed a commit that referenced this issue Jan 3, 2025
@miss-islington @zanieb
[3.13] gh-128456: Use '-reorder-functions=cdsort' for BOLT builds (GH…
b923f48 
…-128457) (#128461)

'hfsort+' is deprecated in favor of 'cdsort'.

(cherry picked from commit 4974bbd)

Co-authored-by: Zanie Blue <[email protected]>
WolframAlph pushed a commit to WolframAlph/cpython that referenced this issue Jan 4, 2025
@zanieb @WolframAlph
pythongh-128456: Use '-reorder-functions=cdsort' for BOLT builds (pyt…
5d34ff1 
…hon#128457)

'hfsort+' is deprecated in favor of 'cdsort'.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
@zanieb @srinivasreddy
pythongh-128456: Use '-reorder-functions=cdsort' for BOLT builds (pyt…
09c45b3 
…hon#128457)

'hfsort+' is deprecated in favor of 'cdsort'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build The build process and cross-build type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-128456: Use -reorder-functions=cdsort for BOLT zanieb/cpython
2 participants
@zanieb @picnixz