Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade doctest CI to Ubuntu-24.04 #128504

Closed
Damien-Chen opened this issue Jan 5, 2025 · 2 comments · Fixed by #128506
Closed

Upgrade doctest CI to Ubuntu-24.04 #128504

Damien-Chen opened this issue Jan 5, 2025 · 2 comments · Fixed by #128506
Labels
infra CI, GitHub Actions, buildbots, Dependabot, etc. type-feature A feature request or enhancement

Comments

@Damien-Chen
Copy link
Contributor

Damien-Chen commented Jan 5, 2025 •
edited by bedevere-app bot
Loading

Feature or enhancement

Proposal:

As title, since most of CI run in ubuntu-24.04, and Doctest CI was pinned to ubuntu-22.04 according to #125236. Maybe we can upgrade it now.

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

No response

Linked PRs
@Damien-Chen Damien-Chen added the type-feature A feature request or enhancement label Jan 5, 2025
@Damien-Chen Damien-Chen mentioned this issue Jan 5, 2025
Merged
@srinivasreddy
Copy link
Contributor

I just wonder is it too much work to maintain a matrix of Ubuntu versions to build against ?

@picnixz picnixz added the infra CI, GitHub Actions, buildbots, Dependabot, etc. label Jan 5, 2025
@hugovk
Copy link
Member

hugovk commented Jan 5, 2025

I don't think it would add much value to run doctest against multiple Ubuntu versions, and it would slow the CI down and use more resources.

hugovk added a commit that referenced this issue Jan 5, 2025
@Damien-Chen @blurb-it @hugovk
gh-128504: Upgrade doctest to ubuntu-24.04 (#128506)
2228e92 
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 5, 2025
@Damien-Chen @blurb-it
@hugovk @miss-islington
pythongh-128504: Upgrade doctest to ubuntu-24.04 (pythonGH-128506)
2d139d3 
(cherry picked from commit 2228e92)

Co-authored-by: Damien <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Jan 5, 2025
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 5, 2025
@Damien-Chen @blurb-it
@hugovk @miss-islington
pythongh-128504: Upgrade doctest to ubuntu-24.04 (pythonGH-128506)
0d5f53a 
(cherry picked from commit 2228e92)

Co-authored-by: Damien <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Jan 5, 2025
Merged
hugovk added a commit that referenced this issue Jan 5, 2025
@miss-islington @Damien-Chen
@blurb-it @hugovk
[3.12] gh-128504: Upgrade doctest to ubuntu-24.04 (GH-128506) (#128518)
09f7d88 
gh-128504: Upgrade doctest to ubuntu-24.04 (GH-128506)
(cherry picked from commit 2228e92)

Co-authored-by: Damien <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk added a commit that referenced this issue Jan 5, 2025
@miss-islington @Damien-Chen
@blurb-it @hugovk
[3.13] gh-128504: Upgrade doctest to ubuntu-24.04 (GH-128506) (#128517)
f6da93a 
gh-128504: Upgrade doctest to ubuntu-24.04 (GH-128506)
(cherry picked from commit 2228e92)

Co-authored-by: Damien <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <[email protected]>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 6, 2025
@Damien-Chen @blurb-it
@hugovk @srinivasreddy
pythongh-128504: Upgrade doctest to ubuntu-24.04 (python#128506)
539b638 
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <[email protected]>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
@Damien-Chen @blurb-it
@hugovk @srinivasreddy
pythongh-128504: Upgrade doctest to ubuntu-24.04 (python#128506)
7a7097f 
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infra CI, GitHub Actions, buildbots, Dependabot, etc. type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-128504: Upgrade doctest to ubuntu-24.04 Damien-Chen/cpython
4 participants
@srinivasreddy @hugovk @picnixz @Damien-Chen