Unwrap type[Union[...]] when solving typevar constraints
#18266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Primer diff is fine, it was a false positive. |
JukkaL
reviewed
Dec 20, 2024
|
Diff from mypy_primer, showing the effect of this PR on open source code: Tanjun (https://github.com/FasterSpeeding/Tanjun)
- tanjun/annotations.py:1064: error: Incompatible return value type (got "object", expected "User | Role | Snowflake | _T") [return-value]
colour (https://github.com/colour-science/colour)
+ colour/geometry/section.py:88: error: Need type annotation for "edge_list" [var-annotated]
- colour/geometry/section.py:90: error: Item "float" of "float | list[float] | list[list[float]] | list[list[list[Any]]]" has no attribute "pop" [union-attr]
- colour/geometry/section.py:91: error: Value of type "Any | float | list[float] | list[list[Any]]" is not indexable [index]
- colour/geometry/section.py:93: error: Argument 1 to "len" has incompatible type "float | list[float] | list[list[float]] | list[list[list[Any]]]"; expected "Sized" [arg-type]
- colour/geometry/section.py:100: error: Item "float" of "float | list[float] | list[list[float]] | list[list[list[Any]]]" has no attribute "pop" [union-attr]
- colour/geometry/section.py:101: error: Value of type "Any | float | list[float] | list[list[Any]]" is not indexable [index]
- colour/geometry/section.py:103: error: Item "float" of "float | list[float] | list[list[float]] | list[list[list[Any]]]" has no attribute "pop" [union-attr]
- colour/geometry/section.py:104: error: Value of type "Any | float | list[float] | list[list[Any]]" is not indexable [index]
+ colour/io/fichet2021.py:682: error: Need type annotation for "chromaticities" (hint: "chromaticities: list[<type>] = ...") [var-annotated]
|
|
Hm, and this new diff is weird. I'll try to figure out the reason for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18265, closes #12115.
type[A | B]is internally represented astype[A] | type[B], and this causes problems for a typevar solver. Prevent using meet in such cases by unwrapingtype[...]if both sides have such shape.