Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to add a benchmark that exercises newer Python features #281

Closed
AlexWaygood opened this issue Apr 25, 2023 · 1 comment · Fixed by #283
Closed

Impossible to add a benchmark that exercises newer Python features #281

AlexWaygood opened this issue Apr 25, 2023 · 1 comment · Fixed by #283

Comments

@AlexWaygood
Copy link
Member

It appears to be currently impossible to add a benchmark that uses a feature added in Python >3.7. Even if you add the requires-python field in the pyproject.toml file for a specific benchmark, the benchmark is run on all Python versions in CI. This means that the CI will fail if the benchmark includes a feature that is new in 3.8, for example.

This issue currently blocks both of these open PRs:

@brandtbucher
Copy link
Member

Yeah, pyperformance should probably check this somehow and refuse to run certain benchmarks based on the advertised Python version support.

Another option could be to disable them by default, and enable them when we drop older version support. But that seems less ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants