Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily tests failed on Tue Dec 24 2024 #13289

Closed
github-actions bot opened this issue Dec 24, 2024 · 3 comments · Fixed by #13290
Closed

Daily tests failed on Tue Dec 24 2024 #13289

github-actions bot opened this issue Dec 24, 2024 · 3 comments · Fixed by #13290
Labels
help wanted An actionable problem of low to medium complexity where a PR would be very welcome

Comments

@github-actions
Copy link
Contributor

Run listed here: https://github.com/python/typeshed/actions/runs/12474672452

@github-actions github-actions bot added the help wanted An actionable problem of low to medium complexity where a PR would be very welcome label Dec 24, 2024
@AlexWaygood
Copy link
Member

Lots of ctypes issues on Windows for pyserial. Possibly related to d8b7ad6? Cc. @tungol

@tungol
Copy link
Contributor

tungol commented Dec 24, 2024

I'll take a look, thanks

@tungol
Copy link
Contributor

tungol commented Dec 24, 2024

The issue is that ctypes._FuncPtr exists now. Previously, it didn't, so the now-failing items didn't have anything to compare to and passed by default. Now that ctypes._FuncPtr exists in the stubs, stubtest finds that the runtime type of ctypes._FuncPtr is not a subtype of the stub annotation ctypes._NamedFuncPointer, and generates a failure. (the annotation ctypes._NamedFuncPointer is actually a subtype of the runtime ctypes._FuncPtr.)

I can move ctypes._FuncPtr to a different name that doesn't coincide with the name of the runtime ctypes.CDLL.__init__.<locals>._FuncPtr class, which would fix the issue by once again making the result of runtime_type = get_mypy_type_of_runtime_value(runtime) be None. That's vaguely dissatisfying, but I'm not sure what better solution is available.

tungol added a commit to tungol/typeshed that referenced this issue Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted An actionable problem of low to medium complexity where a PR would be very welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants