From e468549c55d6d38ff14abe713f02261afe7574f3 Mon Sep 17 00:00:00 2001 From: amyheather Date: Thu, 15 Aug 2024 09:49:26 +0100 Subject: [PATCH] fix(evaluation): amended stress-des 5.3 decision --- evaluation/reporting.qmd | 6 +++--- evaluation/reproduction_report.qmd | 2 +- logbook/posts/2024_08_15/index.qmd | 17 +++++++++++++++++ 3 files changed, 21 insertions(+), 4 deletions(-) create mode 100644 logbook/posts/2024_08_15/index.qmd diff --git a/evaluation/reporting.qmd b/evaluation/reporting.qmd index f80ff6e..5ac4ba3 100644 --- a/evaluation/reporting.qmd +++ b/evaluation/reporting.qmd @@ -16,8 +16,8 @@ This page evaluates the extent to which the journal article meets the criteria f Of the **24** items in the checklist: * **14** were met fully (✅) -* **5** were partially met (🟡) -* **4** were not met (❌) +* **6** were partially met (🟡) +* **3** were not met (❌) * **1** was not applicable (N/A) | Item | Recommendation | Met by study? | Evidence | @@ -48,7 +48,7 @@ Of the **24** items in the checklist: | **Implementation** | | 5.1 Software or programming language | State the operating system and version and build number.
State the name, version and build number of commercial or open source DES software that the model is implemented in.
State the name and version of general-purpose programming languages used (e.g. Python 3.5).
Where frameworks and libraries have been used provide all details including version numbers. | 🟡 Partially | Some details provided - `Methods: Statistics and Software`: "The DES model was built with Simmer (version 4.1.0), a DES package for R. The interactive web application was built with R-Shiny"

@huang_optimizing_2019 | | 5.2 Random sampling | State the algorithm used to generate random samples in the software/programming language used e.g. Mersenne Twister.
If common random numbers are used, state how seeds (or random number streams) are distributed among sampling processes. | 🟡 Partially | Sampling described for arrivals but not for length of time with resources. Doesn't mention whether seeds are used.

`Methods: Model Properties: Patients`: "Patients are generated by a Poissone process with an inter-arrival time as specified in Table 1."
![Table 1. DES model inputs](../original_study/tab1.jpg)
@huang_optimizing_2019 | -| 5.3 Model execution | State the event processing mechanism used e.g. three phase, event, activity, process interaction.
*Note that in some commercial software the event processing mechanism may not be published. In these cases authors should adhere to item 5.1 software recommendations.*
State all priority rules included if entities/activities compete for resources.
If the model is parallel, distributed and/or use grid or cloud computing, etc., state and preferably reference the technology used. For parallel and distributed simulations the time management algorithms used. If the HLA is used then state the version of the standard, which run-time infrastructure (and version), and any supporting documents (FOMs, etc.) | ❌ Not met | - | +| 5.3 Model execution | State the event processing mechanism used e.g. three phase, event, activity, process interaction.
*Note that in some commercial software the event processing mechanism may not be published. In these cases authors should adhere to item 5.1 software recommendations.*
State all priority rules included if entities/activities compete for resources.
If the model is parallel, distributed and/or use grid or cloud computing, etc., state and preferably reference the technology used. For parallel and distributed simulations the time management algorithms used. If the HLA is used then state the version of the standard, which run-time infrastructure (and version), and any supporting documents (FOMs, etc.) | 🟡 Partially | Does not state event processing mechanism. Does describe priority rules - `Methods: Model Properties: Queueing` - e.g. "n our model, emergency IR and stroke patients have higher priority than elective patients for resources. Specifically, angioINRs are capable of both INR and IR procedures, although all patient types... | | 5.4 System specification | State the model run time and specification of hardware used. This is particularly important for large scale models that require substantial computing power. For parallel, distributed and/or use grid or cloud computing, etc. state the details of all systems used in the implementation (processors, network, etc.) | ❌ Not met | - | | **Code access** | | 6.1 Computer model sharing statement | Describe how someone could obtain the model described in the paper, the simulation software and any other associated software (or hardware) needed to reproduce the results. Provide, where possible, the link and DOIs to these. | ✅ Fully | `Methods`: "The source code for the model is available at under a GNU General Public License."

`Methods: Statistics and Software`: "DES model was built with Simmer (version 4.1.0), a DES package for R. The interactive web application was built with R-Shiny"

`Discussion`: "The model is currently available online at "

@huang_optimizing_2019 | diff --git a/evaluation/reproduction_report.qmd b/evaluation/reproduction_report.qmd index bc7c2da..1b81599 100644 --- a/evaluation/reproduction_report.qmd +++ b/evaluation/reproduction_report.qmd @@ -120,7 +120,7 @@ eval_dict = { 'STARS (optional)': [2, 0, 3, 0], 'Badges (criteria)': [3, 0, 9, 0], 'Badges (badges)': [0, 0, 12, 0], - 'STRESS-DES': [14, 5, 4, 1], + 'STRESS-DES': [14, 6, 3, 1], 'ISPOR-SDM': [7, 2, 7, 2] } eval_wide = pd.DataFrame(eval_dict, index=col).T diff --git a/logbook/posts/2024_08_15/index.qmd b/logbook/posts/2024_08_15/index.qmd new file mode 100644 index 0000000..b4d0bd2 --- /dev/null +++ b/logbook/posts/2024_08_15/index.qmd @@ -0,0 +1,17 @@ +--- +title: "Day 15" +author: "Amy Heather" +date: "2024-08-15" +categories: [evaluation] +bibliography: ../../../quarto_site/references.bib +--- + +## Untimed: Amendment to evaluation + +Revisiting the evaluation from each study, I spotted a change to make to the evaluation against STRESS-DES. + +**Criteria:** "5.3 Model execution State the event processing mechanism used e.g. three phase, event, activity, process interaction. Note that in some commercial software the event processing mechanism may not be published. In these cases authors should adhere to item 5.1 software recommendations. State all priority rules included if entities/activities compete for resources. If the model is parallel, distributed and/or use grid or cloud computing, etc., state and preferably reference the technology used. For parallel and distributed simulations the time management algorithms used. If the HLA is used then state the version of the standard, which run-time infrastructure (and version), and any supporting documents (FOMs, etc.)" @monks_strengthening_2019 + +**Original decision:** ❌ Not met + +**New decision:** 🟡 Partially. Does not state event processing mechanism. Does describe priority rules - `Methods: Model Properties: Queueing` - e.g. "n our model, emergency IR and stroke patients have higher priority than elective patients for resources. Specifically, angioINRs are capable of both INR and IR procedures, although all patient types..." \ No newline at end of file