Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lighthouse] use heartbeat info to quickly drop down replicas #35

Open
d4l3k opened this issue Dec 11, 2024 · 0 comments
Open

[lighthouse] use heartbeat info to quickly drop down replicas #35

d4l3k opened this issue Dec 11, 2024 · 0 comments
Labels
enhancement New feature or request lighthouse Lighthouse and quorum related

Comments

@d4l3k
Copy link
Member

d4l3k commented Dec 11, 2024

We currently fallback to the slow quorum path if any replicas fail. We have heartbeat information from all replicas so we should instead use that to detect which replicas are healthy and not wait for them.

https://github.com/pytorch-labs/torchft/blob/main/src/lighthouse.rs#L386

The heartbeat threshold should be configurable though currently we heartbeat every 100ms so 1s timeout seems fine.

We may also want to extract the quorum algorithm into separate configurable/plugable strategies so we can switch between the old and the new logic.

Relevant existing tests:

@d4l3k d4l3k added enhancement New feature or request lighthouse Lighthouse and quorum related labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lighthouse Lighthouse and quorum related
Projects
None yet
Development

No branches or pull requests

1 participant