Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Installation] Warn if submodule wasn't checked out #1534

Closed
cpuhrsch opened this issue Jan 10, 2025 · 3 comments
Closed

[Installation] Warn if submodule wasn't checked out #1534

cpuhrsch opened this issue Jan 10, 2025 · 3 comments
Labels
enhancement New feature or request

Comments

@cpuhrsch
Copy link
Contributor

When installing with python setup.py develop installation will fail unless submodule exists.

PyTorch warns users about this: https://github.com/pytorch/pytorch/blob/bd1f5d1c32fad1d33f9716bc0e7b3924c62e65c1/setup.py#L377-L443

I'd suggest we introduce the same code here.
@cpuhrsch
Copy link
Contributor Author

@alexsamardzic do you mind taking a look at this?

@cpuhrsch cpuhrsch added the enhancement New feature or request label Jan 10, 2025
@alexsamardzic
Copy link
Collaborator

@alexsamardzic do you mind taking a look at this?

Sure, PR is here: #1536.

@alexsamardzic
Copy link
Collaborator

#1536 merged, so closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cpuhrsch @alexsamardzic