Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

Test button is green but in reality, the test job failed #161

Open
janeyx99 opened this issue Oct 18, 2021 · 1 comment
Open

Test button is green but in reality, the test job failed #161

janeyx99 opened this issue Oct 18, 2021 · 1 comment
Labels
bug Something isn't working commit/pr view Issues related to the commit/pr view

Comments

@janeyx99
Copy link

e.g., https://hud.pytorch.org/commit/3b4cb9ddca1cc2b92277541ff781730042bee3c5

image

@driazati driazati added the bug Something isn't working label Oct 21, 2021
@driazati
Copy link
Contributor

The problem here is that the failure happened outside of unittest, so it wasn't included in the XML. This is pretty easy to detect (e.g. https://github.com/pytorch/ci-hud/pull/166/files#diff-3ad9e34ce5052427659516e20bceac132c7cd3e4463470c1371d9dd724b11832R139-R141), and once that lands we can unify it to once place do the same thing here (show a message explaining the issue and hide the results button)

@driazati driazati added the commit/pr view Issues related to the commit/pr view label Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working commit/pr view Issues related to the commit/pr view
Projects
None yet
Development

No branches or pull requests

2 participants