Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc for snapshot_every_n_steps arg param #1301

Closed
wants to merge 1 commit into from

Conversation

gokulavasan
Copy link
Contributor

Summary:

Fixes #1283. Essentially adds the missing doc. Will cherry pick this to release/0.8 once this lands

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Please read through our contribution guide prior to
creating your pull request.

  • Note that there is a section on requirements related to adding a new DataPipe.

Fixes #{1283}

Changes

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@gokulavasan gokulavasan requested a review from atalman July 30, 2024 08:22
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 30, 2024
Copy link

pytorch-bot bot commented Jul 30, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1301

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 82920cf with merge base 2750510 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@gokulavasan
Copy link
Contributor Author

Closing this PR as this has been implemented in #1302

@gokulavasan gokulavasan deleted the sd-param-doc-fix branch July 30, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

best practice for snapshot_every_n_steps
2 participants