-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Just set torch>=2.0 #1210
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This project is in maintenance mode so set it free from having a hard dependency on a single version of PyTorch Signed-off-by: Eli Uriegas <[email protected]>
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Oct 16, 2023
abhinavarora
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for making this change!
Signed-off-by: Eli Uriegas <[email protected]>
@seemethere has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@seemethere merged this pull request in ee4b6ea. |
huydhn
pushed a commit
that referenced
this pull request
Oct 31, 2023
Summary: This project is in maintenance mode so set it free from having a hard dependency on a single version of PyTorch Pull Request resolved: #1210 Reviewed By: abhinavarora Differential Revision: D50347787 Pulled By: seemethere fbshipit-source-id: bb62a8848cb506e21a6024134071e2cf7f729388
This was referenced Nov 1, 2023
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
Summary: This is similar to #1210, but relax the requirement for conda build instead of wheel. For example, `linux-64/torchdata-0.7.0-py39.tar.bz2` conda packages on https://anaconda.org/pytorch-test/torchdata/files currently has the following deps `openssl >=3.0.11,<4.0a0, python >=3.9,<3.10.0a0, pytorch 2.1.0, requests, urllib3 >=1.25, zlib >=1.2.13,<1.3.0a0` where [pytorch](https://anaconda.org/pytorch-test/pytorch) is fixed at `2.1.0` Pull Request resolved: #1213 Reviewed By: seemethere Differential Revision: D50897499 Pulled By: huydhn fbshipit-source-id: cf748914962e00565e2d4f53734fceb429555769
huydhn
added a commit
that referenced
this pull request
Nov 1, 2023
Summary: This is similar to #1210, but relax the requirement for conda build instead of wheel. For example, `linux-64/torchdata-0.7.0-py39.tar.bz2` conda packages on https://anaconda.org/pytorch-test/torchdata/files currently has the following deps `openssl >=3.0.11,<4.0a0, python >=3.9,<3.10.0a0, pytorch 2.1.0, requests, urllib3 >=1.25, zlib >=1.2.13,<1.3.0a0` where [pytorch](https://anaconda.org/pytorch-test/pytorch) is fixed at `2.1.0` Pull Request resolved: #1213 Reviewed By: seemethere Differential Revision: D50897499 Pulled By: huydhn fbshipit-source-id: cf748914962e00565e2d4f53734fceb429555769
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project is in maintenance mode so set it free from having a hard dependency on a single version of PyTorch