Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup DataLoader 2 #1329

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Cleanup DataLoader 2 #1329

wants to merge 6 commits into from

Conversation

andrewkho
Copy link
Contributor

Starting off the cleanup by deleting DataLoader2, CI files, and a bunch of tests

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 27, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 27, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1329

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4b13f2f with merge base 6b762ba (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

divyanshk
divyanshk reviewed Sep 27, 2024
View reviewed changes
torchdata/datapipes/iter/util/prefetcher.py
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do other references to torchdata.datapipes in this file need to stay?

Copy link
Contributor Author

@andrewkho andrewkho Sep 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll just delete the whole thing in one go, i wanted to try and split it up into 2-ish PRs (dlv2 and datapipes) so we can at least have some partial rollback if necessary

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, in that case maybe we want to update the PR title?

Accepting, since tests seem to pass (except some Meta specific bots).

@facebook-github-bot
Copy link
Contributor

@andrewkho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@andrewkho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@divyanshk divyanshk self-requested a review September 27, 2024 20:48
divyanshk
divyanshk approved these changes Sep 27, 2024
View reviewed changes
Copy link

@divyanshk divyanshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewkho andrewkho changed the title Cleanup Datapipes / DLv2 Cleanup DataLoader 2 Sep 27, 2024
@facebook-github-bot
Copy link
Contributor

@andrewkho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyanshk divyanshk divyanshk approved these changes

@ramanishsingh ramanishsingh ramanishsingh approved these changes

@ivy-zhou ivy-zhou Awaiting requested review from ivy-zhou

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewkho @facebook-github-bot @divyanshk @ramanishsingh