Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert wrapper to Cython #45

Open
djhoese opened this issue Nov 26, 2018 · 1 comment
Open

Convert wrapper to Cython #45

djhoese opened this issue Nov 26, 2018 · 1 comment
Labels
category: build enhancement help wanted Primary maintainers may not have time to resolve this priority: low

Comments

@djhoese
Copy link
Member

djhoese commented Nov 26, 2018

As discussed in #37, one option to clean up the aggdraw code is to use cython. As mentioned in #43, I recently noticed that all of the classes in aggdraw are actually declared as factory functions instead of real classes. I don't think any of the aggdraw functionality requires this design so it would be nice if the classes were declared as real classes.

I think the best idea would be to convert the C++ file to cython. This should:

  1. Make the code easier to read
  2. Avoid compatibility issues with new versions of python
  3. Limit unicode/bytes issues and handling

I think this rewrite could wait until aggdraw 2.0 and could look at adding #3's functionality/updating the agg version.

@ismaelharunid
Copy link

ismaelharunid commented Jun 20, 2020

Sounds great. Let's do this.
However it might be worthwhile attempting an implementation in the current version just to get a better idea of strategy and functional redesign, I mean not as changing it but as in how it's implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: build enhancement help wanted Primary maintainers may not have time to resolve this priority: low
Projects
None yet
Development

No branches or pull requests

2 participants