Skip to content
This repository has been archived by the owner on Dec 29, 2024. It is now read-only.

Hang on server failure #46

Open
trsmith2 opened this issue Nov 16, 2018 · 0 comments
Open

Hang on server failure #46

trsmith2 opened this issue Nov 16, 2018 · 0 comments

Comments

@trsmith2
Copy link

I'm seeing a timing dependent hang when the gremlin server goes away for some reason. It looks like the response handler sits on a channel waiting for a response with no timeout. If we get to this blocking call as the server goes down, there is never a response and so this call never unblocks.

https://github.com/qasaur/gremgo/blob/master/response.go#L73

Maybe I missed some setting that would avoid this? Otherwise, my temporary fix is simply to introduce a select/case style timeout, which I've hard coded to a second but I guess could come from some config option.

If you agree I'd be happy to do a PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant