Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating the entire codebase to Typescript #129

Open
Gmin2 opened this issue Nov 15, 2023 · 5 comments
Open

Migrating the entire codebase to Typescript #129

Gmin2 opened this issue Nov 15, 2023 · 5 comments
Labels
wontfix This will not be worked on

Comments

@Gmin2
Copy link

Gmin2 commented Nov 15, 2023

would be very helpful if we migrate the entire codebase of the qdrant-web-ui as it will give more type safety to the code

@generall
Copy link
Member

There are counter-arguments for this https://world.hey.com/dhh/turbo-8-is-dropping-typescript-70165c01?ref=dailydev

@DhairyaMajmudar
Copy link

@generall @kartik-gupta-ij I went through the blog link provided by you that's true that Turbo 8 and is dropping Typescript but still many famous open-source projects like Zulip, Stripe, Prisma etc. are migrating their codebases to Typescript.

Along with that many open source frameworks and libs. like NextJS, NestJS, Angular etc. gained a lot of popularity after migrating to TypeScript in prev. years.

So, I think it will be very beneficial to migrate qdrant-web-ui in Tyepscript.

Stripe Blog
Netligy Blog

@ryuusama09
Copy link

In that case , I would like to take up on this task !

@DhairyaMajmudar
Copy link

DhairyaMajmudar commented Dec 22, 2023

I would also want to take up this task. But I think at first we need confirmation from @generall and @kartik-gupta-ij regarding the same.

@dmgolembiowski
Copy link

TypeScript is a solid choice for a majority of web projects, and that might also be true here as well. But what about migrating the UI to a Rust web framework like leptos?
Qdrant's product is already written in Rust. This means that large amounts of library logic could be imported into the code-base without the need of a Promise or fetch calling another process: to ultimately run the same logic at the expense of using a framework that cannot copy strings by reference because their encodings are different (Utf-16 to Utf-8 and vice-versa). Over time, as qdrant matures we might expect the Web-Ui feature list to grow but the amount of effort to meet those expectations will scale linearly. Instead, being able to call into qdrant's code directly might reduce this from a linear relationship into a logarithmic one (as time goes on less effort is needed).

@generall generall added the wontfix This will not be worked on label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

5 participants