Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Help->About window incorrect formatting #58796

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

agiudiceandrea
Copy link
Contributor

@agiudiceandrea agiudiceandrea commented Sep 19, 2024

Description

This PR fixes the table formatting when QGIS is created by "exported" code (probably an oversight in #57639).
Moreover, it puts the QGIS version and code revision/branch before the Libraries part.

This PR must not be backported.

Current:
image

After merging this PR:
image

@github-actions github-actions bot added this to the 3.40.0 milestone Sep 19, 2024
@agiudiceandrea
Copy link
Contributor Author

@fiddlersfan, what do you think?

Copy link

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 055ceaa)

@nyalldawson nyalldawson merged commit d85f3c2 into qgis:master Sep 19, 2024
31 checks passed
@agiudiceandrea agiudiceandrea deleted the fix-about branch September 19, 2024 21:21
@fiddlersfan
Copy link
Contributor

fiddlersfan commented Sep 20, 2024

@agiudiceandrea: Thanks, yeah i missed that.

Strictly speaking, the OS version and the debug note are not a library either. Should we move these to the top as well?

grafik

@agiudiceandrea
Copy link
Contributor Author

Anyway this PR has been already merged. Would you propose another PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants