Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove psutil patches from test_util.py "through-the-framework" tests #20

Open
ChrisKeefe opened this issue Jun 12, 2020 · 1 comment
Open

Comments

@ChrisKeefe
Copy link
Collaborator

Improvement Description
Remove psutil patches from test_cpu_request_through_framework() and test_more_threads_than_max_stripes()

Current Behavior
These tests are currently running on patched psutil results, due to a bug in psutil's handling of GHA's test runner hardware. This is fine for now, but a little gross.

Proposed Behavior
Remove patches, and let psutil run properly. Note: test runners have two cores, so tests should not call more than two cores.

References
details here

@ChrisKeefe
Copy link
Collaborator Author

ChrisKeefe commented Oct 23, 2020

Note: this PR may take care of our issue. Time to check whether psutil behaves as expected on our test runners. If yes, then we should be good to remove the patches from these tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant