Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative boolean representation #257

Open
thermokarst opened this issue Apr 13, 2021 · 1 comment
Open

Alternative boolean representation #257

thermokarst opened this issue Apr 13, 2021 · 1 comment

Comments

@thermokarst
Copy link
Contributor

Improvement Description
Boolean params are rendered as --p-param / --p-no-param in this interface, but if a default value for the param is set, we render either True or False as the value, which might be a bit confusing when trying to reconcile the relationship with the flag form of the param. I propose replacing the default value with the flag itself.

Current Behavior

  --p-with-replacement / --p-no-with-replacement
                       Rarefy with replacement by sampling from the
                       multinomial distribution instead of rarefying without
                       replacement.                           [default: False]

Proposed Behavior

  --p-with-replacement / --p-no-with-replacement
                       Rarefy with replacement by sampling from the
                       multinomial distribution instead of rarefying without
                       replacement.         [default: --p-no-with-replacement]

References

  1. https://forum.qiime2.org/t/rarefy-table-with-without-replacement-default/19182
@ebolyen
Copy link
Member

ebolyen commented Apr 13, 2021

I dig it, also any machinery which translates this can be further used with the Usage driver, which currently passes True/False (which does work in fact, but it's unusual).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants