Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Enable all pylint checks. #16

Open
11 of 19 tasks
garrison opened this issue May 19, 2022 · 0 comments
Open
11 of 19 tasks

Enable all pylint checks. #16

garrison opened this issue May 19, 2022 · 0 comments

Comments

@garrison
Copy link
Member

garrison commented May 19, 2022 •
edited
Loading

What is the expected enhancement?

Currently, a number of pylint checks are disabled throughout the code base. As we improve the code, we should either fix each check or disable it locally, in preparation for potential contribution to qiskit-optimization.

  • fixme
  • invalid-name
  • too-few-public-methods
  • missing-function-docstring
  • protected-access (waiting on Improve magic rounding to work with all available encodings #7)
  • redefined-outer-name
  • no-member
  • pointless-statement
  • too-many-locals
  • useless-super-delegation
  • consider-using-f-string
  • too-many-statements
  • too-many-branches
  • consider-using-enumerate
  • duplicate-code
  • docstring plugin tests (temporarily disabled in de3bf52)

Currently disabled within notebooks only

  • wrong-import-order
  • wrong-import-position (seems irrelevant, actually)
  • line-too-long
garrison added a commit that referenced this issue May 26, 2022
@garrison
pylint: disable=too-many-statements only where necessary
d080bd6 
partially addresses #16
garrison added a commit that referenced this issue May 27, 2022
@garrison
Enable pylint too-many-locals check
eb9c418 
Partially addresses #16
garrison added a commit that referenced this issue May 27, 2022
@garrison
Fix pylint consider-using-f-string check
86f5e49 
Partially addresses #16
garrison added a commit that referenced this issue May 27, 2022
@garrison
pylint: disable=consider-using-enumerate only where necessary
4c3ae18 
partially addresses #16
garrison added a commit that referenced this issue May 27, 2022
@garrison
Mark each pointless-statement for pylint's sake
082421b 
Partially addresses #16
garrison added a commit that referenced this issue May 27, 2022
@garrison
Fix pylint no-member false positives
1bdeacd 
partially addresses #16
garrison added a commit that referenced this issue May 27, 2022
@garrison
Fix pylint useless-super-delegation warning
7084a23 
partially addresses #16
garrison added a commit that referenced this issue May 27, 2022
@garrison
Enable pylint too-many-branches test
d7d732c 
It seems like we've already fixed this, presumably in
eb9c418.

Partially addresses #16
garrison added a commit that referenced this issue May 27, 2022
@garrison
pylint disable wrong-import-order only where necessary
759e876 
partially addresses #16
garrison added a commit that referenced this issue May 27, 2022
@garrison
Fix pylint line-too-long warnings
dce9586 
Partially addresses #16
garrison added a commit that referenced this issue Jun 2, 2022
@garrison
Add function docstrings to quantum_random_access_optimizer.py
43c64ee 
Partially addresses #16
garrison added a commit that referenced this issue Jun 2, 2022
@garrison
Add additional function and method docstrings
bfb8f68 
Partially addresses #16

Currently, the only files that are lacking such docstrings
are those dealing with magic rounding.  I did not want to create
conflicts with #31.)
garrison added a commit that referenced this issue Jun 9, 2022
@garrison
Copy over the .pylintrc from Qiskit Optimization
9750502 
Since our goal is to contribute this to qiskit-optimization
eventually, it will be good to have the same linter options
as upstream.

Partially addresses #16
@garrison garrison mentioned this issue Jun 9, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@garrison